Support multiple, comma-separated --dns-cluster-ip values
#1685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajohnstone
changed the title
|
Sounds reasonable to me. The linter found an extra space that needs to be removed, @ajohnstone |
|
@cartermckinnon thanks removed extra whitespace :) |
|
@cartermckinnon mind triggering the tests and approval thanks :) |
|
/ci |
|
@cartermckinnon roger that! I've dispatched a workflow. 👍 |
|
@cartermckinnon the workflow that you requested has completed. 🎉
|
cartermckinnon
approved these changes
Mar 4, 2024
cartermckinnon
changed the title
--cluster-dns values
cartermckinnon
changed the title
--cluster-dns values--dns-cluster-ip values
atmosx
pushed a commit
to gathertown/amazon-eks-ami
that referenced
this pull request
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1684
Description of changes:
Support a comma separated list rather than a single scalar value.
bootstrap.sh will override clusterDNS in the kubelet config.
Use case:
This will allow enabling IPVS and node-local by first having node-local and then fall back to the service ip for coredns.
Refer to docs:
https://kubernetes.io/docs/tasks/administer-cluster/nodelocaldns/
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Testing Done
Modified bootstrap and executed on a re-run.
Tests pass, should these not be part of the build workflow?